[Fix] Commands stay Running when user closes their terminal - #1363

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Summary by CodeRabbit

• Bug Fixes

  • Improved handling when terminals close during command execution or shell-integration setup.
  • Prevented commands from starting after a terminal has closed.
  • Ensured active processes complete cleanly without duplicate completion events.
  • Cancelled pending terminal operations and ignored stale events after closure.
  • Improved cleanup when terminals close without reporting an execution result.

• Tests

  • Added coverage for terminal closure, startup races, output delivery, and completion behavior.
  • Added automated lifecycle checks for terminal state transitions.

• Documentation

  • Documented terminal command lifecycle behavior and validation procedures.

Walkthrough

Terminal closure now finalizes active shell processes, cancels pending shell-integration waits, clears terminal state, and prevents duplicate completion. The registry routes close events through this cleanup. Tests and a lifecycle model check cover closure interleavings.

Changes

Terminal closure handling

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  participant VSCodeTerminal
  participant TerminalRegistry
  participant Terminal
  participant TerminalProcess
  VSCodeTerminal->>TerminalRegistry: Emit terminal close
  TerminalRegistry->>Terminal: Call handleClose()
  Terminal->>TerminalProcess: Call handleTerminalClosed()
  TerminalProcess->>Terminal: Complete shell execution with undefined exit code
  TerminalRegistry->>TerminalRegistry: Remove terminal from registry

Explanation

The changed close path can emit a late completion after a process has already failed. TerminalProcess now removes itself from activeProcesses on error (TerminalProcess.ts:47), but the error handler in Terminal.runCommand only rejects the promise (Terminal.ts:125-128); it does not clear terminal.process. If process.run() rejects, a later terminal close sees an empty activeProcesses set and calls shellExecutionComplete({ exitCode: undefined }) (Terminal.ts:94-100). BaseTerminal.shellExecutionComplete() then emits shell_execution_complete for the failed process. This can post an exited status after the command has already failed, which is duplicate lifecycle work caused by disposal.

Resolution

Make process finalization single-owner and idempotent across error and close paths. When startup or stream execution emits error, clear the matching terminal.process, reset terminal execution state, and remove or settle its remaining listeners before releasing it. Alternatively, keep the process tracked until close-safe cleanup completes. In handleClose(), do not call the terminal-wide shellExecutionComplete() fallback when a stale terminal.process exists; finalize that specific process once, or skip completion if its error path already finalized it. Add a regression test that rejects TerminalProcess.run(), closes the terminal, and asserts that onShellExecutionComplete is not called after the rejection.

• X
• Mastodon
• Reddit
• LinkedIn

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.